-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Azure Pipelines config #1038
Conversation
✅ Deploy Preview for blissful-goodall-fa23f6 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I disabled the Azure DevOps auto-deploy based on the master branch trigger. Once all transitions away from Azure DevOps are complete and verified, all the pipelines will be removed. No need for this PR to wait for that to happen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me. It's great seeing the CI check becoming consistent across all the major apps. Consistent naming and usage is going to make long term maintenance easier and ensure all PRs meet testing requirements before they can be merged.
@@ -30,3 +30,6 @@ jobs: | |||
|
|||
- name: Run tests | |||
run: npm test | |||
|
|||
- name: Docker build | |||
run: docker build -t clearlydefined/website:latest . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My take on building the image as part of the test workflow is that it confirms that the PR running the tests did not break the ability to build the docker image. This is a useful block to prevent merge of a PR that will break the docker build that happens on merge to master branch. Is that the intent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was part of the previous Azure DevOps build in the same place and that is my best guess of its intention, yes
We now have a GitHub Actions workflow (#1035), so this will close clearlydefined/crawler#550
Someone with Admin permissions to this repo will need to remove the Pipelines job as a required job and add the Actions build instead.