Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Azure Pipelines config #1038

Merged
merged 4 commits into from
May 30, 2024
Merged

Remove Azure Pipelines config #1038

merged 4 commits into from
May 30, 2024

Conversation

lumaxis
Copy link
Contributor

@lumaxis lumaxis commented Apr 4, 2024

We now have a GitHub Actions workflow (#1035), so this will close clearlydefined/crawler#550

Someone with Admin permissions to this repo will need to remove the Pipelines job as a required job and add the Actions build instead.

@lumaxis lumaxis requested review from elrayle and qtomlinson April 4, 2024 11:17
Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for blissful-goodall-fa23f6 ready!

Name Link
🔨 Latest commit 04b089c
🔍 Latest deploy log https://app.netlify.com/sites/blissful-goodall-fa23f6/deploys/6658745d2054b300085c9db0
😎 Deploy Preview https://deploy-preview-1038--blissful-goodall-fa23f6.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@elrayle
Copy link
Collaborator

elrayle commented May 29, 2024

I disabled the Azure DevOps auto-deploy based on the master branch trigger. Once all transitions away from Azure DevOps are complete and verified, all the pipelines will be removed. No need for this PR to wait for that to happen.

@elrayle elrayle closed this May 29, 2024
@elrayle elrayle reopened this May 29, 2024
Copy link
Collaborator

@elrayle elrayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. It's great seeing the CI check becoming consistent across all the major apps. Consistent naming and usage is going to make long term maintenance easier and ensure all PRs meet testing requirements before they can be merged.

@@ -30,3 +30,6 @@ jobs:

- name: Run tests
run: npm test

- name: Docker build
run: docker build -t clearlydefined/website:latest .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My take on building the image as part of the test workflow is that it confirms that the PR running the tests did not break the ability to build the docker image. This is a useful block to prevent merge of a PR that will break the docker build that happens on merge to master branch. Is that the intent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was part of the previous Azure DevOps build in the same place and that is my best guess of its intention, yes

@lumaxis lumaxis merged commit b3f6e34 into master May 30, 2024
5 checks passed
@lumaxis lumaxis deleted the remove-azure-pipelines branch May 30, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move CI job to GitHub Actions?
2 participants