Add GitHub Actions workflow file to run CI #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blissful-goodall-fa23f6 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
qtomlinson
reviewed
Apr 3, 2024
| @@ -19,7 +19,7 @@ jobs: | |||
|
|
|||
| - uses: actions/setup-node@v4.0.1 | |||
| with: | |||
| node-version: 18 | |||
| node-version: 10 | |||
There was a problem hiding this comment.
DevDockerfile and Dockerfile currently still uses node:10-alpine. In website, npm run start:local-api can run with node 14, but failed with node 16. Potentially using node 14 can be an incremental step to update website.
There was a problem hiding this comment.
Good idea! I'll merge this as is and make a new PR to update everything to 14 🙏🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To complete the switch to GitHub Actions across crawler, service, and website, this adds the same GitHub Actions workflow file that's already running in the other two repos on every pull request.
Once this is merged and verified, I'll follow up with removing the Azure Pipelines config.