This repository has been archived by the owner on Jun 9, 2018. It is now read-only.
Fallback Option for Location/ReverseLookup #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clayton Burlison <git@clburlison.com>
|
The wiki needs to be updated for this FR. |
|
Yeah this is definitely the better way to go, it looks like it works for me. |
If we get to this line 355 we can assume the lookup has failed.
clburlison
added a commit
that referenced
this pull request
Mar 6, 2018
* Implemented the fallback methods for location * Implemented reverse lookup fallback option * Changed the comments to reflect new API * Updated the readme to reflect the new API * Fixed settings to pull from the pref file * refactor: Move google lookup into separate method * fix: Lint lookup google method Signed-off-by: Clayton Burlison <git@clburlison.com> * refactor: Move apple lookup into separate method * feat: Re-add fallback with logic handling in main * style: Use new docstring formatting on lookup() * fix: Correct fallback var for reverse lookup * fix: Update pre-commit hook * fix: lookup_apple should not throw exception If we get to this line 355 we can assume the lookup has failed. Co-authored-by: Daniel Anner <daniel.anner@danstechsupport.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite of #32.