This repository has been archived by the owner on Jun 9, 2018. It is now read-only.
[FR] Fallback Option for Location/ReverseLookup #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clburlison
reviewed
Feb 27, 2018
| if args.fallback: | ||
| toFallback = True | ||
| else: | ||
| toFallback = False |
There was a problem hiding this comment.
You should pull from the config here. pref('Fallback')
|
Whoops, missed that one! Thanks for catching, I updated it. |
|
Did you have a chance to review this? if so, it would be great to have it in the master branch. |
|
@danner26 I just got time to review this. I'm happy with the feature enhancement addition but not the implementation. Using exceptions for core logic handling is pretty dirty. Since I was delayed on the review I've gone ahead and refactored this. Please see #33 and see if you're happy with the changes I've made. If so I'll go ahead with the merged and cut a new patch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support and CLI switch for fallback. If Apple lookup fails, and if the command is specified, it will try to redo the lookup through Google. Likewise, if the Apple reverse lookup fails, and if the command is specified, it will try to redo the reverse lookup through Google.