Remove compass mixins #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_1 Upvote_ As mentioned in #975, compass-mixins has a bug that prevents us from updating node-sass to ^3.5.0 (Igosuki/compass-mixins#84, Igosuki/compass-mixins#85). Also, it looks like the official repository is no longer being maintained (Igosuki/compass-mixins#86 fixes the issue, but it's not merged).
Since there are some other bugs in compass-mixins that were fixed but not merged, I think we should remove this dependency (or fork and maintain it). In this PR, I'm using node-bourbon instead of compass-mixins as our mixin library for Sass, allowing us to update node-sass to the latest version (closes #970).
Additionally, since there are no reset utilities in bourbon, I've imported compass
nested-resetmixin to our base scss path.What do you guys think? Any feedback is appreciated!