Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken on node-sass@^3.5.0 #84

Closed
loganfsmyth opened this issue Apr 21, 2016 · 34 comments
Closed

Broken on node-sass@^3.5.0 #84

loganfsmyth opened this issue Apr 21, 2016 · 34 comments

Comments

@loganfsmyth
Copy link

Compiling this library with gulp-sass using node-sass 3.5.0, this is now broken and throwing

    node_modules/compass-mixins/lib/compass/functions/_lists.scss
Error: Functions may not be defined within control directives or other mixins.
        on line 81 of node_modules/compass-mixins/lib/compass/functions/_lists.scss
>>   @function compact($vars...) {
   --^
@loganfsmyth
Copy link
Author

Sounds like it was a bug that this worked previously: sass/node-sass#1456

@phazei
Copy link

phazei commented Apr 21, 2016

+1
Please fix ASAP

@Qing-xiu
Copy link

+1

3 similar comments
@hellonoam
Copy link

+1

@dschaller
Copy link

+1

@jmphilli
Copy link

+1

@cbrwizard
Copy link

@Kopatch
Copy link

Kopatch commented Apr 21, 2016

+1

2 similar comments
@lxlang
Copy link

lxlang commented Apr 21, 2016

+1

@VasuLief
Copy link

+1

@VasuLief
Copy link

you can replace this package with https://www.npmjs.com/package/compass-sass-mixins and it should work just fine

@fustic
Copy link

fustic commented Apr 21, 2016

+1

1 similar comment
@Predjo
Copy link

Predjo commented Apr 21, 2016

+1

@VasuLief
Copy link

you could also set a fixed version of node-sass@3.4.2 in your packages.json

@E-VANCE
Copy link

E-VANCE commented Apr 21, 2016

you could also set a fixed version of node-sass@3.4.2 in your packages.json

Didn't do the trick for me...
+1

@dschaller
Copy link

If you're using grunt-sass it requires node-sass as well so you'd have to shrinkwrap in order to pin

ungoldman added a commit to ungoldman/gulp-sass that referenced this issue Apr 21, 2016
@ungoldman
peg node-sass to 3.4.x
6aa48a1 
temp fix until Igosuki/compass-mixins#84 is resolved
@jrowlingson jrowlingson mentioned this issue Apr 22, 2016
Closed
xzyfer added a commit to xzyfer/compass-mixins that referenced this issue Apr 23, 2016
@xzyfer
Always define compact
964c7d5 
This implement of compact is functionally equivalent of the
unofficial native one that has been permanently removed from LibSass.
There is no risk in always using this version. The version of LibSass
that had a `compact` function is extremely difficult to obtain, and
is long unsupported.

More importantly defining function inside control structures is not
valid in Sass and produces errors for people using this library.

Fixes Igosuki#84
Fixes Igosuki#85
@xzyfer xzyfer mentioned this issue Apr 23, 2016
Merged
@xzyfer
Copy link
Collaborator

xzyfer commented Apr 23, 2016

Fix PR'd in #86

@navgarcha
Copy link

+1

robertknight added a commit to hypothesis/h that referenced this issue May 3, 2016
@robertknight
Remove compass-mixins dependency
9ec8694 
The immediate problem this dependency causes is that it it fails to
build with the current version of node-sass (see
Igosuki/compass-mixins#84) which in turn means
that H cannot be built with Node 6.0. Removing this dependency allows
the node-sass dependency to be unpinned so that the current version
can be used.

The primary functionality that compass-mixins was used for was vendor
prefixing, which is now taken care of by autoprefixer, plus CSS fixes
for browsers which we no longer support (IE < 10).

For the remaining handful of mixins for resets and color mixing which we
are still using, this commit just extracts the few lines of code for
each directly from compass and includes it directly in our SCSS files.
robertknight added a commit to hypothesis/h that referenced this issue May 3, 2016
@robertknight
Remove compass-mixins dependency
31003e8 
The immediate problem this dependency causes is that it it fails to
build with the current version of node-sass (see
Igosuki/compass-mixins#84) which in turn means
that H cannot be built with Node 6.0. Removing this dependency allows
the node-sass dependency to be unpinned so that the current version
can be used.

The primary functionality that compass-mixins was used for was vendor
prefixing, which is now taken care of by autoprefixer, plus CSS fixes
for browsers which we no longer support (IE < 10).

For the remaining handful of mixins for resets and color mixing which we
are still using, this commit just extracts the few lines of code for
each from the compass documentation and includes it directly in our SCSS
files.
robertknight added a commit to hypothesis/h that referenced this issue May 3, 2016
@robertknight
Remove compass-mixins dependency
9be804d 
The immediate problem this dependency causes is that it it fails to
build with the current version of node-sass (see
Igosuki/compass-mixins#84) which in turn means
that H cannot be built with Node 6.0. Removing this dependency allows
the node-sass dependency to be unpinned so that the current version
can be used.

The primary functionality that compass-mixins was used for was vendor
prefixing, which is now taken care of by autoprefixer, plus CSS fixes
for browsers which we no longer support (IE < 10).

For the remaining handful of mixins for resets and color mixing which we
are still using, this commit just extracts the few lines of code for
each from the compass documentation and includes it directly in our SCSS
files.
@robertknight robertknight mentioned this issue May 3, 2016
Merged
@fetis
Copy link

fetis commented May 3, 2016

It's more than 11 days since fix is available. Any ideas when it'll be merged?

@mdular
Copy link

mdular commented May 4, 2016

+1 for an ETA on the fix

@jsha09
Copy link

jsha09 commented May 4, 2016

+1

xzyfer added a commit to xzyfer/compass-mixins that referenced this issue May 4, 2016
@xzyfer
Always define compact
7245feb 
This implement of compact is functionally equivalent of the
unofficial native one that has been permanently removed from LibSass.
There is no risk in always using this version. The version of LibSass
that had a `compact` function is extremely difficult to obtain, and
is long unsupported.

More importantly defining function inside control structures is not
valid in Sass and produces errors for people using this library.

Fixes Igosuki#84
Fixes Igosuki#85
xzyfer added a commit to xzyfer/compass-mixins that referenced this issue May 4, 2016
@xzyfer
Always define compact
7dc37c2 
This implement of compact is functionally equivalent of the
unofficial native one that has been permanently removed from LibSass.
There is no risk in always using this version. The version of LibSass
that had a `compact` function is extremely difficult to obtain, and
is long unsupported.

More importantly defining function inside control structures is not
valid in Sass and produces errors for people using this library.

Fixes Igosuki#84
Fixes Igosuki#85
@xzyfer
Copy link
Collaborator

xzyfer commented May 4, 2016

PR is updated a passing. Turn out the transition mixin has never worked on offical Sass compiler.

@GFoley83
Copy link

GFoley83 commented May 5, 2016 •
edited
Loading

+1 I'm using grunt-sass like @dschaller which requires node-sass. Adding the node-sass dependency manually in the package.json solves the issue for me:

  "devDependencies": {
    ...
    "node-sass": "3.4.2",
    ...
  }

Remember to either rebuild node-sass or delete the module folder and re-install.

@orzarchi
Copy link

orzarchi commented May 7, 2016

+1

@svaldi
Copy link

svaldi commented May 7, 2016

+1 Since, there is a problem with the node-sass also in the darwin-x64-48_binding.node when you use a node-sass 3.4.2 version. If we use 3.4.2 temporary this is not a favorable option.

@tjenkinson tjenkinson mentioned this issue May 7, 2016
Merged
@jeanschmidt
Copy link

+1

@ale-grosselle
Copy link

+1, please!

@runderworld
Copy link

+1 por favor!

@bernardocamilo bernardocamilo mentioned this issue May 10, 2016
Merged
@henk23
Copy link

henk23 commented May 12, 2016

+1

@xzyfer
Copy link
Collaborator

xzyfer commented May 14, 2016

Hello everyone, I've gotten in contact with @Igosuki and I'll now be helping out maintaining this project. This should prevent further breakages.

@xzyfer
Copy link
Collaborator

xzyfer commented May 14, 2016 •
edited
Loading

compass-mixins@0.12.8 has been released

@svaldi
Copy link

svaldi commented May 16, 2016

Thank you so much to everyone!!!!!

@kevinleguillou kevinleguillou mentioned this issue Oct 11, 2016
Open
@ismaail
Copy link

ismaail commented Apr 4, 2018

Hi, I'm getting this error trying to compile mdb.scss from MDBootstrap

Module build failed: ModuleBuildError: Module build failed: 
    @function set-notification-text-color($color) {
             ^
      Functions may not be defined within control directives or other mixins.
      in /home/user/project/assets/MDBootstrap/scss/core/_mixins.scss (line 215, column 15)
  • compass-mixins: ^0.12.10
  • node-sass: ^4.8.3
  • node version: v9.10.1
  • npm version: 5.8.0

@xzyfer
Copy link
Collaborator

xzyfer commented Apr 4, 2018

This package is no longer supported. We recommended using http://bourbon.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests