Refactored fetch #16
Merged
Refactored fetch #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng of MovieCards and CharacterCards
Container and CharacterCard to pass data down, made an example object (myself) to be rendered to the page
…ts as we go through each fetch call, issues arise when trying to use Promise.all
…all character objs created
…ck to render route
|
@ckoga Interesting! I created this new branch after getting the fetches to process correctly on your fetch-branch and it shows all the commits including yours from the original branch. I like it! |
|
Merging now the last commit adds styling to CharacterCards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
-Breaks out our fetch calls into several individual functions within our method that is invoked on the click of View Characters button.
-Successfully fetches and accesses all the data we need.
-Creates an array of character objects with that data and sets it as state
Where should the reviewer start?
-Walk through the fetch calls within the fetchHandler() method
-Pay attention to what/where we are using
returnandPromise.all()-The fetchChar() method was renamed fetchHandler(). This has been updated across App > DisplayContainer > MovieCard. Testing for these components may be affected by this and other changes.
How should this be manually tested?
Uncomment out the initial fetch and walk through the app from Welcome Form through displaying Characters. Characters are display (need css) but the previous data displays while the fetch is processing.
Any background context you want to provide?
What are the relevant tickets?
Issue #14 has been opened to address the UI/UX impact of the delay during fetching
Issue #15 has been opened because we have not yet implemented .catch() or error handling for the fetches
Screenshots (if appropriate)
This shows how the state of App has correctly updated after fetching the data. The issue of the 7th character repeating infinitely is no longer occurring. Only 10 characters are being displayed per the spec.