Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Loading to character display #14

Open
hfaerber opened this issue Dec 9, 2019 · 0 comments
Open

Add Loading to character display #14

hfaerber opened this issue Dec 9, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@hfaerber
Copy link
Collaborator

hfaerber commented Dec 9, 2019 •
edited
Loading

The previous this.state.characters displays while waiting for the fetches to resolve and update state.

*We will also want to reset this.state.characters to an empty array when users navigate away from the character page so that that it doesn't show the last movie's characters while loading the currently selected movie's characters

A loading icon will be important for UI/UX
@hfaerber hfaerber added the enhancement New feature or request label Dec 9, 2019
@hfaerber hfaerber mentioned this issue Dec 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hfaerber