-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev/drupal#193 Replace custom installer with Civi\Setup #679
Conversation
(Standard links)
|
The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/drupal/-/issues/193 |
Interesting fail:
so I guess we'll be able to see if this PR helps for that fail: civicrm/civicrm-core#29311 |
* Don't need to setup a web-page controller (`$ctrl`) * Fix inheritance of default`server` when it has an alternate port * Options chosen via drush-cli should override autodetected options * This is the most substantive part of the change. I had trouble installing to an alternate DB. The reason is that `init()` actually kicks of auto-detection of things like DB. If the installer-client wants to set its own value of `$model->db`, then it's best to do after `init()`.
@mlutfy Very nice! I did some For my testing, I used these commands: ## Use second database. Leave `lang` empty.
drush civicrm-install --dbhost=127.0.0.1:3307 --dbname=dmastercivi_3r007 --dbuser=dmasterciv_4i5or --dbpass=XXX \
--tarfile=/dev/null -l http://dmaster.127.0.0.1.nip.io:8001 -vv
## Use second database. Set locale to en_US.
drush civicrm-install --dbhost=127.0.0.1:3307 --dbname=dmastercivi_3r007 --dbuser=dmasterciv_4i5or --dbpass=XXX \
--tarfile=/dev/null -l http://dmaster.127.0.0.1.nip.io:8001 -vv --lang=en_US --langtarfile=/dev/null
## Use second database. Set locale to fr_FR.
drush civicrm-install --dbhost=127.0.0.1:3307 --dbname=dmastercivi_3r007 --dbuser=dmasterciv_4i5or --dbpass=XXX \
--tarfile=/dev/null -l http://dmaster.127.0.0.1.nip.io:8001 -vv --lang=fr_FR --langtarfile=/dev/null
## Use single database. Set locale to de_DE.
drush civicrm-install --tarfile=/dev/null -l http://dmaster.127.0.0.1.nip.io:8001 -vv --lang=de_DE --langtarfile=/dev/null
## Use single database. Leave `lang` empty.
drush civicrm-install --tarfile=/dev/null -l http://dmaster.127.0.0.1.nip.io:8001 -vv With the patch, they're all working for me. (I didn't test anything that requires downloading a tar file -- but it looks like that stuff wasn't touched by the patch.) Note: The reported failure ( |
jenkins, test this please |
@totten thanks for the testing & fix! That translation bug is on my radar too. I don't think it's been fixed? |
jenkins retest this please (the localized one should pass now) |
https://lab.civicrm.org/dev/drupal/-/issues/193
Replaces the custom CiviCRM installer by the better-supported
\Civi\Setup
.This only impacts people still using drush8 (ex: Aegir).