(dev/core#1615) Remove the very old CiviCRM installer

[mlutfy]

Overview

It has been replaced by \Civi\Setup a long time ago, but the drush integration was still using it.

This might make some tests fail?

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[totten]

Wow, this'll be great.

Pre-depends: civicrm/civicrm-drupal#679

@mlutfy Looks like CRM/Core/CodeGen/I18n.php would re-generate install/langs.php. So maybe we can drop that line too?

[demeritcowboy]

I'm not sure what the extended tests are telling us but the last time I tried using this installer it couldn't even get going because recent versions of mariadb don't like this line.

So +1

[mlutfy]

Test fails include:

• api\v4\Afform\AfformRoutingTest.testChangingPath
• E2E\Core\LocalizedDataTest.testLocalizedData

The upgrade suite seems to fail on:

++ civi-test-run -b build-1 -j /home/homer/workspace/CiviCRM-Test-QLow/build/junit --exclude-group ornery upgrade
(Clock simulation) Tests will use inherited option TIME_FUNC=linear:500
ls: cannot access '/home/homer/buildkit/build/build-1/web/core//tests/phpunit/Upgrade/*.php': No such file or directory

I'm not very familiar with those tests, but they all seem unrelated?

[demeritcowboy]

The testChangingPath one is a known fail: https://lab.civicrm.org/dev/drupal/-/issues/197
The testLocalizedData one I thought was fixed at https://lab.civicrm.org/dev/translation/-/issues/84 but maybe the node that is running on needs some kind of update?

[demeritcowboy]

I think this is mergeable just there's the earlier note about langs.php, but that doesn't have to be in here.

[totten]

civibot, test this please

[totten]

(Note: The HEAD commit predates the current test-jobs, so Github shows a mix of old+new jobs. The important results will be CiviCRM-PR, run-distmaker, run-extended-tests.)

[colemanw]

run-extended-tests fails appear to be unrelated or preexisting?

[totten]

Agree @colemanw - all pre-existing.

r-run: I took the tar/zip files for Backdrop, Joomla, Drupal 7, WordPress -- and did a GUI-based installation. As expected, they all ran cleanly.

[colemanw]

Yay!