CRM-20008 repattrasasction create pending membership with pending con… #9827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes - multiple memberships per contribution IS a thing. I'm not quite loving the memberships_pending key replacing the memberships key. I think I'll need to find time to look a bit more thoroughly but my feeling on first glance is it probably does need to be pushed deeper. I'll come back to it |
|
Closing as #10030 is merged & replaces |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tribution
This kind of thing could be moved further down stream into_ipn_process_transaction, but I wanted to avoid affecting other calls that use that function.
Are multiple memberships per contribution a thing? I believe this would support it! Looks like someone is thinking about this since when related objects are loaded, membership is an array.