CRM-20008 repattrasasction create pending membership with pending con…

…tribution
civicrm · Feb 12, 2017 · 3287d76 · 3287d76
1 parent 4f4e28f
commit 3287d76
Show file tree

Hide file tree

Showing 2 changed files with 69 additions and 1 deletion.
diff --git a/api/v3/Contribution.php b/api/v3/Contribution.php
@@ -640,7 +640,36 @@ function civicrm_api3_contribution_repeattransaction(&$params) {
     );
     $input = array_intersect_key($params, array_fill_keys($passThroughParams, NULL));
 
-    return _ipn_process_transaction($params, $contribution, $input, $ids, $original_contribution);
+    $notRenewing = array('Failed', 'Overdue', 'Refunded', 'Partially paid', 'Pending refund', 'Chargeback');
+    $contributionStatuses = CRM_Contribute_PseudoConstant::contributionStatus(NULL, 'name');
+
+    // CRM-20008 create pending memberships with pending contribution.
+    if (isset($params['contribution_status_id']) && isset($contribution->_relatedObjects['membership']) && ($contributionStatuses[$params['contribution_status_id']] == 'Pending')) {
+      $contribution->_relatedObjects['memberships_pending'] = $contribution->_relatedObjects['membership'];
+      unset($contribution->_relatedObjects['membership']);
+        foreach ( $contribution->_relatedObjects['memberships_pending'] as $membership ){
+          $pendingMembership = civicrm_api3('Membership', 'create', array(
+             'id' => $membership->id,
+             'membership_type_id' => $membership->membership_type_id,
+             'contact_id' => $membership->contact_id,
+             'contribution_recur_id' => $membership->contribution_recur_id,
+             'num_terms' => 1,
+             'status_id' => 'Pending',
+            ));
+      }
+    }
+
+    $ipnProcessTransaction = _ipn_process_transaction($params, $contribution, $input, $ids, $original_contribution);
+    // Create any neccesary any Membership Payments now that we have a contribution id.
+    if (isset($params['contribution_status_id']) && isset($contribution->_relatedObjects['memberships_pending']) && ($contributionStatuses[$params['contribution_status_id']] == 'Pending')) {
+      foreach ( $contribution->_relatedObjects['memberships_pending'] as $membership ){
+        civicrm_api3('MembershipPayment', 'create', array(
+           'contribution_id' => $ipnProcessTransaction['id'],
+           'membership_id' => $membership->id,
+          ));
+      }
+    }
+    return $ipnProcessTransaction;
   }
   catch(Exception $e) {
     throw new API_Exception('failed to load related objects' . $e->getMessage() . "\n" . $e->getTraceAsString());

diff --git a/tests/phpunit/api/v3/ContributionTest.php b/tests/phpunit/api/v3/ContributionTest.php
@@ -2131,6 +2131,44 @@ public function testRepeatTransactionUsesCompleted() {
     $this->contactDelete($originalContribution['values'][1]['contact_id']);
   }
 
+  /**
+   * CRM-20008 Tests repeattransaction creates pending membership.
+   */
+  public function testRepeatTransactionPendingMembership() {
+    list($originalContribution, $membership) = $this->setUpAutoRenewMembership();
+
+    $this->callAPISuccess('membership', 'create', array(
+       'id' => $membership['id'],
+       'end_date' => 'yesterday',
+       'status_id' => 4,
+    ));
+
+    $repeatedContribution = $this->callAPISuccess('contribution', 'repeattransaction', array(
+       'contribution_recur_id' => $originalContribution['values'][1]['contribution_recur_id'],
+       'contribution_status_id' => 'Pending',
+       'trxn_id' => uniqid(),
+    ));
+
+    $membershipStatusId = $this->callAPISuccess('membership', 'getvalue', array(
+      'id' => $membership['id'],
+      'return' => 'status_id',
+    ));
+    // Return the name for our memebership status id.
+    $membershipStatusName = CRM_Core_DAO::getFieldValue('CRM_Member_DAO_MembershipStatus',
+      $membershipStatusId,
+      'label', 'id'
+    );
+    // Let's see if the membership payments got created while we're at it.
+    $membershipPayments = $this->callAPISuccess('MembershipPayment', 'get', array(
+      'contribution_id' => $repeatedContribution['id'],
+    ));
+
+    $this->assertNotEquals(0, $membershipPayments['count']);
+    $this->assertEquals('Pending', $membershipStatusName);
+    $this->quickCleanUpFinancialEntities();
+    $this->contactDelete($originalContribution['values'][1]['contact_id']);
+  }
+
   /**
    * CRM-16397 test appropriate action if total amount has changed for single line items.
    */
@@ -3213,6 +3251,7 @@ protected function setUpAutoRenewMembership($generalParams = array(), $recurPara
       'financial_type_id' => "Member Dues",
       'duration_unit' => "month",
       'duration_interval' => 1,
+      'period_type' => 'rolling',
       'name' => "Standard Member",
       'minimum_fee' => 100,
     ));