Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-19692: Fix js error on Submit Credit Card Contribution form #9469

Merged
merged 1 commit into from
Dec 2, 2016
Merged

CRM-19692: Fix js error on Submit Credit Card Contribution form #9469

merged 1 commit into from
Dec 2, 2016

Conversation

jitendrapurohit
Copy link
Contributor

@jitendrapurohit jitendrapurohit commented Nov 30, 2016 •
edited by civicrm-builder
Loading

@jitendrapurohit jitendrapurohit mentioned this pull request Nov 30, 2016
Closed
@jitendrapurohit
Copy link
Contributor Author

jenkin, retest this please

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

@KarinG over to you to test this & confirm

@KarinG
Copy link
Contributor

KarinG commented Dec 1, 2016

Will do - with new RC tomorrow.

@KarinG
Copy link
Contributor

KarinG commented Dec 2, 2016 •
edited
Loading

Ok - I copied Jitendra's edits into today's RC and can now see the pricesets. Some CSS work needed but we can save for later. It's rather important we bring this back.

lineitems

@seamuslee001
Copy link
Contributor

Agree with the testing from @KarinG replicated the same issue and works with fix on my 4.7.14-rc dev spot

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@eileenmcnaughton
Copy link
Contributor

So this is a consensus to merge?

@seamuslee001
Copy link
Contributor

That would be my impression @eileenmcnaughton

@monishdeb monishdeb merged commit 561fc04 into civicrm:4.7.14-rc Dec 2, 2016
@jitendrapurohit jitendrapurohit deleted the CRM-19692-4.7.14-rc branch December 2, 2016 10:59
@KarinG
Copy link
Contributor

KarinG commented Dec 3, 2016

Double checked this w/ civicrm-4.7.14-drupal-20161202.tar.gz 02-Dec-2016 16:42 17M - all good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
4.7.14-rc merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jitendrapurohit @eileenmcnaughton @KarinG @seamuslee001 @monishdeb @civicrm-builder