-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRM-19692: Fix js error on Submit Credit Card Contribution form #9465
Conversation
jitendrapurohit
commented
Nov 29, 2016
•
edited by civicrm-builder
Loading
edited by civicrm-builder
- CRM-19692: Cannot select Priceset in Backend: Contributions: Submit Credit Card Contribution
Hi - I pulled over this afternoon's civicrm-4.7.14-drupal-20161129.tar.gz
But I am still not able to get a priceset to work in Backend: Contributions: Submit Credit Card Contribution - Errors in Firebug Console: SyntaxError: missing } after function body I tried checking this on http://dmaster.demo.civicrm.org/ as well - but can't login at the moment / connecting... |
Is it possible that perhaps your fixes are not in the rc yet? |
Yes no diff (yet): |
@KarinG this is not merged so will not be in the rc |
(also PR is against master not the rc) |
It has a purple merge button? I can see it was against master - not rc. |
It has a green merge button for me... Since you have described this as a regression I would consider it for the rc if you manage to test it & @jitendrapurohit confirms he feels comfortable with that. |
Agree that it should be merged into rc. I've raised fix at #9469 |
closing in favor of #9469 |