Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-19692: Fix js error on Submit Credit Card Contribution form #9465

Closed
wants to merge 1 commit into from

Conversation

jitendrapurohit
Copy link
Contributor

@jitendrapurohit jitendrapurohit commented Nov 29, 2016

@KarinG
Copy link
Contributor

KarinG commented Nov 30, 2016

Hi - I pulled over this afternoon's civicrm-4.7.14-drupal-20161129.tar.gz

  • cleared all drupal and civicrm caches

But I am still not able to get a priceset to work in Backend: Contributions: Submit Credit Card Contribution - Errors in Firebug Console:

SyntaxError: missing } after function body
ReferenceError: buildAmount is not defined

backendps

I tried checking this on http://dmaster.demo.civicrm.org/ as well - but can't login at the moment / connecting...

@KarinG
Copy link
Contributor

KarinG commented Nov 30, 2016

Is it possible that perhaps your fixes are not in the rc yet?

@KarinG
Copy link
Contributor

KarinG commented Nov 30, 2016

Yes no diff (yet):
karins-macbook-pro:Downloads sysadmin$ diff civicrm_nov28rc/templates/CRM/Contribute/Form/Contribution.tpl civicrm_nov29rc/templates/CRM/Contribute/Form/Contribution.tpl
karins-macbook-pro:Downloads sysadmin$

@eileenmcnaughton
Copy link
Contributor

@KarinG this is not merged so will not be in the rc

@eileenmcnaughton
Copy link
Contributor

(also PR is against master not the rc)

@KarinG
Copy link
Contributor

KarinG commented Nov 30, 2016

It has a purple merge button? I can see it was against master - not rc.

@eileenmcnaughton
Copy link
Contributor

It has a green merge button for me...

Since you have described this as a regression I would consider it for the rc if you manage to test it & @jitendrapurohit confirms he feels comfortable with that.

@jitendrapurohit
Copy link
Contributor Author

Agree that it should be merged into rc. I've raised fix at #9469

@jitendrapurohit
Copy link
Contributor Author

closing in favor of #9469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants