Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-18713 - SMS #8527

Closed
wants to merge 2 commits into from
Closed

CRM-18713 - SMS #8527

wants to merge 2 commits into from

Conversation

jmcclelland
Copy link
Contributor

@jmcclelland jmcclelland commented Jun 7, 2016 •
edited by civicrm-builder
Loading

@jmcclelland
CRM-18713: ensure SMS activities are sent to all contacts
0dcee12 
Only try to fill in details if we have tokens to replace. Otherwise
our array gets populated with all data for the contact and the mobile
number carefully chosen is lost.
@jmcclelland
CRM-18713 - We only care if tokens are present in the message
bbb63c4 
We don't care whether custom tokens are defined or not - if tokens
are in the message, try to replace them with either core or custom
token replacements.
@jmcclelland jmcclelland mentioned this pull request Jun 7, 2016
Closed
@totten totten changed the title Crm 18713 CRM-18713 - SMS Jun 11, 2016
@JoeMurray
Copy link
Contributor

Jamie, as Release Manager this month, I'm trying to recruit people to help pare down the backlog of almost 100 PRs, some going back to last summer. I'm wondering if you would be able to help QA another PR if I got someone to QA this PR?

@MegaphoneJon
Copy link
Contributor

@JoeMurray Since I know it's a matter of time before you post one of these messages on one of my PRs - you can put me down for this one. I've been working on SMS recently.

@jmcclelland
Copy link
Contributor Author

Sure Joe - you can assign me a ticket to QA

@JoeMurray
Copy link
Contributor

Thanks, @PalanteJon - I put you down for another before noticing your message here (again).

@MegaphoneJon
Copy link
Contributor

I know that most QA conversations are happening on Github, but since
there was already a significant conversation on Jira, I updated it there.

@JoeMurray JoeMurray mentioned this pull request Jul 7, 2016
Closed
@davejenx
Copy link
Contributor

davejenx commented Oct 12, 2016 •
edited
Loading

Hi @jmcclelland ! At the Edale sprint, trying to review/close some PRs. Reading the conversation at CRM-18713, has this PR been superseded by later ones: #8626 (merged) & #8628 (open)? If so, can this one be closed?

@jmcclelland
Copy link
Contributor Author

Yes #8626 supercedes this pull request. It would be nice to get #8628 merged, but that is a more significant change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmcclelland @JoeMurray @MegaphoneJon @davejenx @civicrm-builder