CRM-18713: ensure SMS activities are sent to all contacts

[jmcclelland]

Only try to fill in details if we have tokens to replace. Otherwise
our array gets populated with all data for the contact and the mobile
number carefully chosen is lost.

https://issues.civicrm.org/jira/browse/CRM-18713

[joseltorres]

volunteering to review

[joseltorres]

I could not replicate this issue.

I have tested this scenario with civi 4.6 and found that once I chose the drop down to send sms, the correct mobile phone was in the TO box on the compose form. Civi pulled the correct mobile phone although it was not the primary phone number.

It's also my belief that your change could cause additional issues because if (!empty($returnProperties) || !empty($tokens)) would never result in TRUE if the site has no custom tokens. You may want to check an review any custom code that defines any custom tokens. Maybe you can also provide more context, were you using twilio or clickatell? I am also assuming that you're running on civi 4.6 since both twilio and clicktell extensions are not yet compatible with 4.7.

[colemanw]

Closing for the moment, feel free to reopen if above questions are addressed.

[joseltorres]

@jmcclelland once the changes to the PR are made that are mentioned in the JIRA issue, this PR should be good to merge

https://issues.civicrm.org/jira/browse/CRM-18713?focusedCommentId=90024&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-90024

[jmcclelland]

New PR: #8527

Thanks!