dev/core#5449 set NOINDEX on non-public event registration pages #31074
Conversation
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
|
The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/5449 |
CRM/Event/Form/Registration.php
Outdated
| } | ||
|
|
||
| /** | ||
| * Assign the minimal set of variables to the template. | ||
| */ | ||
| public function assignToTemplate() { | ||
| //process only primary participant params | ||
| $this->_params = $this->get('params'); |
There was a problem hiding this comment.
I think it was a mistake that this line was moved.
There was a problem hiding this comment.
my mistake, thanks for spotting!
magnolia61
force-pushed
the
noindex_metatag_for_non-public_event_registration_pages
branch
2 times, most recently
from
ff0e661
to
d995c8e
Compare
magnolia61
force-pushed
the
noindex_metatag_for_non-public_event_registration_pages
branch
from
d995c8e
to
7bb8e36
Compare
|
@magnolia61 how about this alternative - #31083 - mostly I feel like setting specific default headers is the sort of thing that could change in the future due to an internet change & if that happened we would want to have one function to change |
Hi Eileen, love this. I'm a very limited coder, just enough to read, understand & tweak what we need. The solution you propose is rocksolid. I think it is really your quality to always look into medium and long-term in civi-development. Thank you for that! |
|
Merged via #31083 |
Overview
non-public event registration pages are still indexed by search engines
this pr adds a no-index to registration pages for non-public events
Gitlab issue: https://lab.civicrm.org/dev/core/-/issues/5449
Before
non-public event registration pages are still indexed by search engines
After
non-public event registration pages get a NOINDEX metatag in the html header
Comments
A while ago https://issues.civicrm.org/jira/browse/CRM-21639 already added NOINDEX for the event info pages (#11496 & #11498) But this was not done fior the event registration pages. This pr add the same metatag to the event registration pages if the event is a non-pubkic event