CRM-21639 NOINDEX on print preview pages

[magnolia61]

Overview

CiviCRM Print Preview pages should not be indexed by search engines

Before

Print preview pages (snippets) are indexed by google and cause confusion and possible worse than possible rankings.

After

Print Preview pages do not get indexed by compliant search engines

Technical Details

The PR adds META NAME="ROBOTS" CONTENT="NOINDEX, NOFOLLOW" to the head of the Print Preview

Comments

This patch will not remove old print preview pages from google, but a legitimate site owner can remove them using the Google Search Console. With the NOINDEX tag in place they will not be re-indexed.

---

• CRM-21639: Event pages should be set to NoIndex when event is not public or in the past

[seamuslee001]

Jenkins re test this please

[mlutfy]

jenkins, test this please

[JoeMurray]

This looks fairly safe at one level, but print.tpl and PRINT_PAGE are deep in our core files:

./CRM/Core/Selector/Controller.php: $content = self::$_template->fetch('CRM/common/print.tpl');

./CRM/Core/Controller.php: return 'CRM/common/print.tpl';

./CRM/Core/Smarty.php: // use print.tpl and bypass the CMS. Civi prints a valid html file

./CRM/Core/Page.php: $content = self::$_template->fetch('CRM/common/print.tpl');

./templates/CRM/Admin/Page/APIExplorer.tpl: <% if(join.children) print(tpl({joins: join.children, tpl: tpl})); %>

./templates/CRM/common/snippet.tpl: {include file="CRM/common/print.tpl"}

./CRM/Contact/Page/View/Print.php: $this->_print = CRM_Core_Smarty::PRINT_PAGE;

./CRM/Core/Controller.php: if ($this->_print == CRM_Core_Smarty::PRINT_PAGE) {

./CRM/Core/Smarty.php: PRINT_PAGE = 1,

So I'd just want to make sure that the testing on this is well thought through to ensure no quiet but troublesome use cases are missed.

[colemanw]

To my eye this looks safe & straightforward. I'm not sure what potential issues could arise from this that we should test for @JoeMurray - did you have anything in mind?

[magnolia61]

@colemanw is there anything we need to check or do to get this merged?
When I look at the list of @JoeMurray I cannot relate that to specific pages to check
It is only inserted in the print preview modus where also the print.css is loaded.

[colemanw]

I can't think of any reason this wouldn't be safe.