Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev/core#5278 - Missing page title on angular pages #30373

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jun 7, 2024

Overview

Fixes missing page title on CMSs other than D7.

Before

Angular pages such as FormBuilder forms display "CiviCRM" as the title on D9, WP & Joomla (although it works correctly on D7).

After

Correct title displayed.

Technical Details

This regressed probably due to a combination of #28560 and #29694

This regressed probably due to a combination of civicrm#28560 and civicrm#29694
Copy link

civibot bot commented Jun 7, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Jun 7, 2024
@colemanw colemanw changed the base branch from master to 5.75 June 7, 2024 19:51
@civibot civibot bot added 5.75 and removed master labels Jun 7, 2024
@demeritcowboy demeritcowboy added the merge ready PR will be merged after a few days if there are no objections label Jun 10, 2024
@demeritcowboy
Copy link
Contributor

I've put merge-ready only because I can't reproduce the problem in drupal 10, but I do see it on wpmaster.demo and a wp test site https://test.civicrm.org/job/CiviCRM-Manual/298/console built with the patch applied fixes it.

@demeritcowboy demeritcowboy merged commit 2954f0b into civicrm:5.75 Jun 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.75 merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants