Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afform - fix missing page title #29694

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Mar 10, 2024

Overview

Fixes missing title when viewing Afform as a full page.

Before

Page title missing.

After

Title visible on the page and in the browser tab.

Technical Details

Evidently this regressed in 3ee3a88. Not quite sure how the bug slipped in.

Copy link

civibot bot commented Mar 10, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the 5.72 label Mar 10, 2024
@kurund
Copy link
Contributor

kurund commented Mar 11, 2024

@colemanw

This patch fixes the issue with missing title.

This issue exist on 5.70.x hence, I think we should backport it to 5.71 branch.

@colemanw
Copy link
Member Author

retest this please

@colemanw colemanw added the merge ready PR will be merged after a few days if there are no objections label Mar 14, 2024
@kurund
Copy link
Contributor

kurund commented Mar 14, 2024

test this please

@colemanw
Copy link
Member Author

@civicrm-builder retest this please

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton eileenmcnaughton merged commit f362d88 into civicrm:5.72 Mar 15, 2024
3 checks passed
@eileenmcnaughton eileenmcnaughton deleted the afformTitle branch March 15, 2024 21:42
colemanw added a commit to colemanw/civicrm-core that referenced this pull request Jun 7, 2024
This regressed probably due to a combination of civicrm#28560 and civicrm#29694
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.72 merge ready PR will be merged after a few days if there are no objections sig:regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants