ScheduledReminders - Refactor form to work at a standalone url

[colemanw]

Overview

One more form in an ongoing effort to decouple pages from forms. This one is for Scheduled Reminders.

Before

Form coupled with page. Exhibits bug in #26344

After

Form and page decoupled following standard pattern used for other admin forms. Bug fixed as a byproduct (https://lab.civicrm.org/dev/core/-/issues/4309).

[civibot]

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers

• ➡️ Demo site for this PR
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

[totten]

If you look at the main listing page (/civicrm/admin/scheduleReminders?reset=1), the Add Reminder button still goes to the old URL (e.g. http://core-26884-62nfn.test-1.civicrm.org:8001/civicrm/admin/scheduleReminders?action=add&reset=1). Shouldn't that change to match?

[totten]

On the "Edit" screen on the autobuild test site, I see this warning - which I don't remember seeing before:

User warning: Smarty error: unable to read resource: "CRM/Admin/Form/ScheduleReminders.hlp" in Smarty->trigger_error() (line 1100 of /home/jenkins/bknix-dfl/build/core-26884-62nfn/web/sites/all/modules/civicrm/packages/Smarty/Smarty.class.php).

[totten]

OK, cool, that is better.

I tested a bit with multi-tab usage (as in dev/core#4309). Each tab stores the data as you would expect. Woot.

One last thing, though -- after you submit the form, where should you go? Before, it returned to the listing screen (civicrm/admin/scheduleReminders) -- now, it goes to the site-root (/). Granted, most people probably don't open this page in secondary tabs. But if the site is set to ajaxPopupsEnabled=0, then the redirect feels more problematic.

[colemanw]

Thanks for the review @totten - I'm working on a metadata-driven solution for the redirects that can apply to every CRM_Admin_Form, not just this one, because I see all the decoupled forms now have this problem.