dev/core#4309 Fix schedule reminder getting overwritten #26344
Conversation
|
(Standard links)
|
CRM/Admin/Form/ScheduleReminders.php
Outdated
| parent::preProcess(); | ||
|
|
||
| $this->_id = CRM_Utils_Request::retrieve('id', 'Positive'); | ||
| } |
There was a problem hiding this comment.
@chrisgaraffa I think is not necessary to override the preprocess to assign the $this->_id because the parent class already does that here. Or is it not working earlier?
|
@monishdeb Thanks for checking that (and sorry for the delayed response here) - You're right, I just tested against 5.63.1 and the preProcess isn't necessary. |
|
I've started reviewing this PR and got a bit lost in the long convoluted history of this issue. I'll pick this back up once I have a better grasp of the big picture here. Bookmarking a few things I've uncovered so far:
|
|
OK! It turns out that this is resolved indirectly via #26884 |
Overview
Fixes Schedule Reminder form to use an id form field instead of getting the id value from the session.
Before
https://lab.civicrm.org/dev/core/-/issues/4309 outlines the issue - opening the Edit link for multiple Scheduled Reminders in new tabs/windows and saving any but the most recently opened causes the most recently opened reminder gets overwritten.
After
Now uses a hidden id field to store the ID rather than the session.
Comments
Based on fixes for contributions and participants in #14244