Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecentItems - additional fix for inconsistent option values #24653

Merged
merged 1 commit into from
Oct 1, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Sep 30, 2022

Overview

Followup to #24632 - this fixes incorrect values created by the 5.53.0 installer.

Technical Details

The problem with #24164 is that both the installer AND the upgrader were incorrect. So it's a multi-step process to fix all permutations of incorrectness :)
#24632 fixed the incorrect data written by the upgrader, but didn't account for new sites installed with 5.53.0. This fixes the latter.

Comments

It's confusing to read because the first UPDATE sets value to name and the second sets name to value, but the WHERE clause distinguishes the data created by the upgrader vs by the installer.

@civibot
Copy link

civibot bot commented Sep 30, 2022

(Standard links)

@civibot civibot bot added the 5.54 label Sep 30, 2022
@demeritcowboy demeritcowboy merged commit c5fb3ff into civicrm:5.54 Oct 1, 2022
@demeritcowboy
Copy link
Contributor

I didn't test all variations here, and I'm not sure what's happening with 5.53.1
I do note that civicrm_generated needs redoing.

@colemanw colemanw deleted the fixRecentItemsOptionGroup2 branch November 9, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants