RecentItems - additional fix for inconsistent option values #24653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Followup to #24632 - this fixes incorrect values created by the 5.53.0 installer.
Technical Details
The problem with #24164 is that both the installer AND the upgrader were incorrect. So it's a multi-step process to fix all permutations of incorrectness :)
#24632 fixed the incorrect data written by the upgrader, but didn't account for new sites installed with 5.53.0. This fixes the latter.
Comments
It's confusing to read because the first UPDATE sets
value
toname
and the second setsname
tovalue
, but the WHERE clause distinguishes the data created by the upgrader vs by the installer.