dev/core#3783 convert Recent Items providers into an option group

[herbdool]

Overview

Fixes https://lab.civicrm.org/dev/core/-/issues/3783

Before

Recent Items providers is a hard-coded list.

After

Adds an option group and uses that instead.

I'm not quite sure if I've got the right place to put the upgrade query. I haven't tried it for core yet.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Normally we try to write upgrade code in a way that's safe to be run multiple times.
The way this upgrader is written, it's going to crash if it's already been run once.
I think the way the upgrade code is written is actually the right way to write install sql, and it should be moved to the installer.
For the upgrader, I would do it in php rather than a sql file, and take advantage of the failsafe functions \CRM_Core_BAO_OptionGroup::ensureOptionGroupExists and \CRM_Core_BAO_OptionValue::ensureOptionValueExists

[herbdool]

I've updated it. I figured eventually it would be in php, but as I was looking around it seemed like it would temporarily in sql/*.tpl until closer to the release. Anyway, I guess I was wrong.

[colemanw]

@herbdool this looks good. The sql you wrote is still needed though, it just needs to be placed in civicrm_data.tpl for the sake of new installs (or a slight variation of it, see how option groups and values are created in that file).

[herbdool]

@colemanw I added it to civicrm_data.tpl too. All tests pass

[colemanw]

I tested this and added one additional safeguard. Everything else looks fine and works as expected.