Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade task to handle %A date format specifier change #24077

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

demeritcowboy
Copy link
Contributor

Overview

See #24032 (comment)

Alternative to #24070

As @seamuslee001 noted there is some difficulty in accurately detecting use of %A with date_format (as opposed to crmDate) where it's ok and correct to use %A, and in fact the event receipt template currently does use it. But I think I've got it pretty close.

Before

After

If it detects you are using %A in a message template it might look something this:

Untitled4

Otherwise it looks like this (this will be the typical experience):

Untitled5

Technical Details

See #24032 (comment)

Comments

@civibot
Copy link

civibot bot commented Jul 28, 2022

(Standard links)

@civibot civibot bot added the master label Jul 28, 2022
@seamuslee001
Copy link
Contributor

This looks right to me I'll give it an r-run locally shortly

@seamuslee001
Copy link
Contributor

I r-runed this locally and confirmed it works as expected good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants