[REF] Add in Post Upgrade message about %A format change #24070
Conversation
|
(Standard links)
|
seamuslee001
force-pushed
the
remove_dependency_strftime
branch
from
5b91cd5
to
ec1483c
Compare
| @@ -21,6 +21,16 @@ | |||
| */ | |||
| class CRM_Upgrade_Incremental_php_FiveFiftyThree extends CRM_Upgrade_Incremental_Base { | |||
|
|
|||
| public function setPostUpgradeMessage(&$postUpgradeMessage, $rev) { | |||
| if ($rev === '5.53.alpha1') { | |||
| $postUpgradeMessage .= '<br/>' . ts("WARNING: CiviCRM has changed our the date format variable %1 is outputted when using CRM_Core_Date::customFormat / crmDate. Please review your <a href='%2' target='_blank'>Date Format</a> settings and your <a href='%3' target='_blank'>system message templates</a> for usage of the %1 variable", [ | |||
There was a problem hiding this comment.
CiviCRM has changed our the date format variable
our => how ?
Also CRM_Utils_Date not Core_Date. But I think I'll put up an alternate PR because while a message is still good, it seems safe to just go ahead and have the upgrade replace %A with %P in any of the settings on the admin page, and for message templates it could tell you which ones have the string %A in them.
There was a problem hiding this comment.
The tricky part is that if it is date_format|%A is fine but not crmDate|%A
There was a problem hiding this comment.
For the settings on the admin page they don't have smarty code in them and are purely format strings, so I think it's safe to just replace there. In message templates yes there might be all kinds of whack.
|
closing in favour of #24077 |
Overview
This is a follow up to #24032 as per suggestion from Dave D
Before
No Post upgrade message
After
There is a post upgrade message about change in %A output
ping @demeritcowboy