Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] extract and share code to determine if required contact fields are present #19302

Merged
merged 1 commit into from
Jan 5, 2021
Merged

[REF] extract and share code to determine if required contact fields are present #19302

merged 1 commit into from
Jan 5, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jan 1, 2021 •
edited
Loading

Overview

[REF] extract and share code to determine if required contact fields are present

Before

Identical code in activity import & participant import - a la copy & paste

After

Extracted function shared

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jan 1, 2021

(Standard links)

@civibot civibot bot added the master label Jan 1, 2021
@eileenmcnaughton eileenmcnaughton changed the title [REF] extract and share code to determine if required contact fields … [REF] extract and share code to determine if required contact fields are present Jan 1, 2021
@eileenmcnaughton
Copy link
Contributor Author

test this please

1 similar comment
@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton eileenmcnaughton mentioned this pull request Jan 4, 2021
Merged
@demeritcowboy
Copy link
Contributor

demeritcowboy commented Jan 5, 2021 •
edited
Loading

  • General standards
    • [r-explain] PASS
    • [r-user] PASS
    • [r-doc] PASS
    • [r-run] PASS
  • Developer standards
    • [r-tech] PASS
    • [r-code] PASS There's some pre-existing awkward use of ts/concatenation/br.
    • [r-maint] ____
    • [r-test] PASS

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 @colemanw ok to merge based on ^^

@seamuslee001 seamuslee001 merged commit fef8050 into civicrm:master Jan 5, 2021
@seamuslee001 seamuslee001 deleted the act_map branch January 5, 2021 21:39
@eileenmcnaughton
Copy link
Contributor Author

thanks @demeritcowboy @seamuslee001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @demeritcowboy @seamuslee001