[REF] Fix import signature on activity parser, add preliminary test

[eileenmcnaughton]

Overview

Minor preliminary cleanup

Before

public function __construct(&$mapperKeys)

2/3 of the places that instantiate it pass in unused parameters

After

public function __construct($mapperKeys)

Technical Details

The construct class does not need to receive mapperKeys as a reference - this
was removed for Membership Parser here 14b9e06#diff-36f5db3555445d26df2de015a18598fd5d5682b76c62aee4f14dde95b7948274L65

In addition 2 places that instantiate this class pass in unused params (go copy & paste) so
that is removed. The test tests very little so far....

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[eileenmcnaughton]

@demeritcowboy I don't know if you have hit it but it's not currently possible to update an activity by import. I think the fix might not actually be that hard (I have more commits locally that follow on from this one & #19302 ) - not sure if this is functionality you have an interest in

[demeritcowboy]

There was an older PR where that came up - the framework is there the radio just isn't placed on the form and then the final pieces at the end. Let me see if I can find.

[demeritcowboy]

Link: #17932 (comment)

[eileenmcnaughton]

@demeritcowboy hmm - I think there is more stuff in the validation code too. TBH I'm not sure why we need the checkbox - if the id field is there & mapped an update makes sense I think (I don't think the underlying code for replace vs fill is there but it is when I get the other parts cleaned up I'll revive it)

[demeritcowboy]

Ok I don't fully remember, but I can review this one later today.

[demeritcowboy]

• General standards
  • [r-explain] PASS
  • [r-run] PASS
• Developer standards
  • [r-code] PASS
  • [r-test] PASS

[eileenmcnaughton]

thanks @demeritcowboy - @seamuslee001 @colemanw can someone merged based on above review