Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Duplicate possibly-used parts of createProfileContact onto Parser_Contact #19098

Merged
merged 1 commit into from
Dec 4, 2020

Commits on Dec 3, 2020

  1. [REF] Duplicate possibly-used parts of createProfileContact onto Pars…

    …er_Contact
    
    The parser_Contact class should call the api. Getting to that point is
    complicated because
    1) it's such a mess and
    2) it does a lot of work to prepare to call createProfileContact
    and it's hard to unravel that.
    
    By copying most of createProfileContact onto the class we can start to
    unravel it & pare down to calling the api (note we went through
    this process in the dedupe class, at least in part).
    
    I'm pretty sure the hooks reflect 'the way the code grew up' rather than
    any logical use/ requirement for the profile hook
    eileenmcnaughton committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    29f811d View commit details
    Browse the repository at this point in the history