[REF] Duplicate possibly-used parts of createProfileContact onto Parser_Contact #19098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
This looks fine to me and we should have plenty of test coverage here |
eileenmcnaughton
changed the title
|
Test fails look related @eileenmcnaughton |
…er_Contact The parser_Contact class should call the api. Getting to that point is complicated because 1) it's such a mess and 2) it does a lot of work to prepare to call createProfileContact and it's hard to unravel that. By copying most of createProfileContact onto the class we can start to unravel it & pare down to calling the api (note we went through this process in the dedupe class, at least in part). I'm pretty sure the hooks reflect 'the way the code grew up' rather than any logical use/ requirement for the profile hook
eileenmcnaughton
force-pushed
the
import
branch
from
8108d7d
to
29f811d
Compare
|
That test is pretty nice actually. I think I've fixed it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Duplicate possibly-used parts of createProfileContact onto Parser_Contact
Before
Lots of work done to call toxic function - very opaque
After
Possibly salient parts duplicated, facilitating more cleanup
Technical Details
The parser_Contact class should call the api. Getting to that point is
complicated because
and it's hard to unravel that.
By copying most of createProfileContact onto the class we can start to
unravel it & pare down to calling the api (note we went through
this process in the dedupe class, at least in part).
I'm pretty sure the hooks reflect 'the way the code grew up' rather than
any logical use/ requirement for the profile hook
Comments