Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core#2105: Groups children now get shown with SPAN CSS error #18718

Closed
wants to merge 1 commit into from

Conversation

monishdeb
Copy link
Member

Overview

The child group label now show raw HTML before it.

Before

Screenshot 2020-10-09 at 9 53 45 AM

Screenshot 2020-10-09 at 9 56 35 AM

After

Screenshot 2020-10-09 at 9 54 44 AM

Screenshot 2020-10-09 at 9 55 43 AM

Technical Details

I am not sure what is the recent style changes made which is affecting the group widget and didn't find the cause of the regression as this wasn't a issue before 5.29.0. I looked on my earlier PR #17927 and on reverting this patch it doesn't fix the problem and I tried to lookup further but still got no clue. As a quick fix I have used - as a spacer for child group as this technique is already been used in here , meatime I will continue my work to find a correct fix so that use of HTML spacer text is possible to use.

Comments

ping @eileenmcnaughton @lcdservices @MikeyMJCO

@civibot
Copy link

civibot bot commented Oct 9, 2020

(Standard links)

@civibot civibot bot added the master label Oct 9, 2020
@eileenmcnaughton
Copy link
Contributor

@monishdeb can you switch to branch 5.31?

@monishdeb
Copy link
Member Author

Done #18719

@monishdeb monishdeb closed this Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants