dev/core#785 Differentiate smart group from regular group using icon in select2 field

[monishdeb]

Overview

Currently, there is no way to tell which group is smart or regular group from UI. It would be ideal to use icon against such smart group options to differentiate them from regular ones. This patch appends an icon against smart group option of the select2 widget

https://lab.civicrm.org/dev/core/-/issues/785

Before

After

Comments

resubmitted PR after fixing the regression encountered in https://lab.civicrm.org/dev/core/-/issues/1888

ping @eileenmcnaughton @demeritcowboy @lcdservices

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Thanks @monishdeb the fatal is gone but it still has the error where it doesn't show the group when editing an existing contact who has a group, e.g. http://core-17927-5hal8.test-1.civicrm.org:8001/civicrm/contact/add?reset=1&action=update&cid=204, with the warning about htmlspecialchars.

[monishdeb]

Thanks @demeritcowboy for pointing that issue. I have updated the PR. Please have a look now.

[demeritcowboy]

1. One of the errors from before is still there it just takes more work to get to it now. See also https://github.com/civicrm/civicrm-core/pull/17877/files which is where I started on this error before if that helps.
   a. Find or create a contact that has a group assigned.
   b. Edit the contact and in the tags and groups section at the bottom of the form remove all the groups. It doesn't remove the group(s) and you get warnings:

   1. Warning: array_key_exists() expects parameter 2 to be array, string given in CRM_Contact_Form_Contact->postProcess() (line 952 of .../CRM/Contact/Form/Contact.php).
   2. Warning: Invalid argument supplied for foreach() in CRM_Contact_BAO_Contact::create() (line 309 of .../CRM/Contact/BAO/Contact.php).

2. There's also a line missing but it's my fault because the first revert wasn't clean. You want to put this line back to get the star to appear on the mailing form: https://github.com/civicrm/civicrm-core/pull/13958/files#diff-f295dee2f5355df7c28f695ba8757d00R103

3. Also can you squash commits?

[demeritcowboy]

The array() syntax seems to have come back. While I personally prefer array() the civi standard is now square brackets.

[demeritcowboy]

CRM_Utils_Array::value is being mercilessly removed everywhere in civi. So it should be the original line $group = $params['group'] ?? NULL;

[monishdeb]

@demeritcowboy thanks for your thorough code review. I have fixed all the issues you have raised. Please have a look now.

[demeritcowboy]

I just have one more thing: line 109 just below also needs title removed, e.g. if you add Group to a profile.

[monishdeb]

@demeritcowboy actually its fine, because its affecting only the group select widget, which now takes the array of information instead of just group title, as now we are supporting select2. The reason why the entire $group array is set, Whereas for advanced checkbox widget, it still needs only the group title as per old behaivour.

[demeritcowboy]

Try adding group to a profile though and then using the profile.

[monishdeb]

oops my bad ... updated now

[demeritcowboy]

Ok thanks looks good there's just the title note above.

I think the block in CRM/Contact/Form/Contact.php can be simplified but it works as-is so can leave for some other time.

[demeritcowboy]

Looks good. I'm done.

[eileenmcnaughton]

OK thanks for all your review on this @demeritcowboy

[monishdeb]

Thanks a lot, @demeritcowboy for thoroughly reviewing this patch