dev/core#2073 Remove memory leak in heavily tested (merge) code

[eileenmcnaughton]

Overview

dev/core#2073 Remove memory leak in heavily tested (merge) code

Before

Use of $dao->query($query); - which is a legacy pattern previously to cause memory leaks

After

  $dao = CRM_Core_DAO::executeQuery($query);

Technical Details

There are dozens of tests that pass through these lines - I used api_v3_JobTest:testBatchMerge to step through it

• note the dao->affectedRows uses a query to determine that - so it is no more or less accurate than before

Comments

Example tests

message: 'Failure in api call for relationship create: yep it is tested'
severity: fail
...
not ok 1970 - Failure: api_v3_RelationshipTest::testRelationshipCreateDuplicateWithCustomFields

message: 'Failure in api call for relationship create: yep it is tested'
severity: fail
...
not ok 1971 - Failure: api_v3_RelationshipTest::testRelationshipCreateDuplicateWithCustomFields2

message: 'Failure in api call for relationship create: yep it is tested'
severity: fail

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).