Merge pull request #18692 from eileenmcnaughton/leak1

dev/core#2073 Remove memory leak in heavily tested (merge) code
civicrm · Oct 7, 2020 · 0957ca2 · 0957ca2
2 parents 829489b + 411f09c
commit 0957ca2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/CRM/Dedupe/BAO/RuleGroup.php b/CRM/Dedupe/BAO/RuleGroup.php
@@ -212,7 +212,6 @@ public function fillTable() {
     $patternColumn = '/t1.(\w+)/';
     $exclWeightSum = [];
 
-    $dao = new CRM_Core_DAO();
     CRM_Utils_Hook::dupeQuery($this, 'table', $tableQueries);
 
     while (!empty($tableQueries)) {
@@ -257,7 +256,7 @@ public function fillTable() {
 
           // construct and execute the intermediate query
           $query = "{$insertClause} {$query} {$groupByClause} ON DUPLICATE KEY UPDATE weight = weight + VALUES(weight)";
-          $dao->query($query);
+          $dao = CRM_Core_DAO::executeQuery($query);
 
           // FIXME: we need to be more acurate with affected rows, especially for insert vs duplicate insert.
           // And that will help optimize further.
@@ -279,7 +278,7 @@ public function fillTable() {
         $fieldWeight = $fieldWeight[0];
         $query = array_shift($tableQueries);
         $query = "{$insertClause} {$query} {$groupByClause} ON DUPLICATE KEY UPDATE weight = weight + VALUES(weight)";
-        $dao->query($query);
+        $dao = CRM_Core_DAO::executeQuery($query);
         if ($dao->affectedRows() >= 1) {
           $exclWeightSum[] = substr($fieldWeight, strrpos($fieldWeight, '.') + 1);
         }

diff --git a/CRM/Dedupe/Finder.php b/CRM/Dedupe/Finder.php
@@ -47,13 +47,12 @@ public static function dupes($rgid, $cids = [], $checkPermissions = TRUE) {
     }
 
     $rgBao->fillTable();
-    $dao = new CRM_Core_DAO();
-    $dao->query($rgBao->thresholdQuery($checkPermissions));
+    $dao = CRM_Core_DAO::executeQuery($rgBao->thresholdQuery($checkPermissions));
     $dupes = [];
     while ($dao->fetch()) {
       $dupes[] = [$dao->id1, $dao->id2, $dao->weight];
     }
-    $dao->query($rgBao->tableDropQuery());
+    CRM_Core_DAO::executeQuery(($rgBao->tableDropQuery()));
 
     return $dupes;
   }