Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/financial#151 Paypal express validation fix on event #18680

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

extension of #18459

Before

validation error

After

Fixed

Technical Details

@Stoob does this fix it? I have some doubt about versions though - this looks like the 5.31 fix - but @seamuslee001 would it work on older versions?

Comments

@civibot
Copy link

civibot bot commented Oct 6, 2020

(Standard links)

@civibot civibot bot added the master label Oct 6, 2020
@seamuslee001
Copy link
Contributor

@eileenmcnaughton i did a r-run of this locally on master and 5.30 and the change worked for the register however I have yet to test the add Payment form (as annon I presume) I'm thinking that the safest option maybe to add rather than replace these 2 button title options in and also put this against 5.30

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 ok - I can do that & comment it

@eileenmcnaughton eileenmcnaughton changed the base branch from master to 5.30 October 7, 2020 21:20
@civibot civibot bot added 5.30 and removed master labels Oct 7, 2020
@eileenmcnaughton
Copy link
Contributor Author

ok @seamuslee001 done

@eileenmcnaughton eileenmcnaughton merged commit 5c0576a into civicrm:5.30 Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants