dev/financial#147 Ensure that jQuery Validation doesn't execute when …

[seamuslee001]

…we click the paypal express button and ensure the style of the button doesn't change

Overview

The aim of this is to fix a regression where by jquery validation was checking for credit card fields to be validated before allowing the form to be submitted which isn't the correct case when selecting the express button for PayPal Pro payment processor.

Before

Form doesn't submit when submitting using PayPal Pro payment processor and clicking on the Express button

After

Form submits and we rely on the PHP / Quickform validation layer to ensure that enough fields are filled in.

Technical Details

This changes the button from an image imput into a class which may have some style issues down the track. However this does mean that we can pass in the attribute formnovalidate which stops jQuery validation from firing when the user clicks on the button

ping @agh1 @eileenmcnaughton @Stoob @mattwire

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

This works for me. Is that enough to merge now or do we want further input? I'm mindful we need to test against 5.29 as well

[eileenmcnaughton]

Too form-layer to test

[eileenmcnaughton]

MOPing as @Stoob commented on gitlab that it passed his testing