dev/core#1928 Fix HTML5 error due to required attribute being set swi…

[seamuslee001]

…tch to using a class as jquery.validation picks up the class as well

See: https://lab.civicrm.org/dev/core/-/issues/1928

Overview

To reproduce the error create a custom field set that applies to any activity and that is collapsed by default and have a radio varchar field added that is required. Go to create a custom field and find you cannot submit form due to an console error.

Before

Cannot create new cases with a hidden required radio field

After

Radio field still properly validated and also still picked up by jquery validation

ping @demeritcowboy @eileenmcnaughton @totten

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

r-run: Tested before and after the patch. It now shows a decent error message about the omitted field. 👍

[demeritcowboy]

Thanks for the PR and thanks for testing. Just want to clarify there's (at least) two places to check here:

1. The case activity form, where jquery validation doesn't seem to be active, so there this is about html5 getting in the way.
2. Profiles used on contribution pages that contain required radios, where jquery validation is active, and what the original PR and problem-ish warning was about, which led to another PR which led us here. I just tested that spot and that's still working.