Fix JQuery Validation for radios

[seamuslee001]

Overview

This fixes the jQuery validation for radio html objects by ensuring that the required attribute is properly set on radio html objects and that the error message is correctly placed

Before

1. Create a profile that includes the gender field as a required field
2. Set that profile to be used on a contribution page
3. Navigate to the live contribution page
4. Open up the console and enter in CRM.$('#Main').valid();
5. Note that in the console you get a message about it being invalid but note there is no visual display that the gender is a required field

After

Repeat Steps 1-4 as above but in step 5 you should find that for the radio field there is a new message that it is a required field sitting next to the radios

ping @demeritcowboy @mattwire @colemanw

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

I added this in because at the moment CRM_Core_Form::add 's function declaration makes no sense for radios better to use the addRadio function instead

[demeritcowboy]

Tested and overall this works.

I was wondering if it's just radios that need this, so I also checked checkboxes. It works but behaves differently with stripe vs not stripe, but I'm not sure if that's a flaw in jquery validate? With stripe (which I assume is using jquery validate), you have to check all the checkboxes. With not-stripe, required just means you have to pick at least one checkbox, which matches what I'd expect.

[eileenmcnaughton]

this is very form layer so I think it's OK without test.

My take on this is that it is mergeable but that perhaps there is more that should be considered. Adding merge-ready to give @seamuslee001 & @demeritcowboy space to loop back in on the last comment

[mattwire]

@demeritcowboy Stripe currently loads in some overrides for jquery validate to make it work properly without modifying CiviCRM core.

This should be tested using the following in the browser console (without stripe loaded):
For testing you can do in the browser console on a contribution page:
var validator = CRM.$('#Main').validate();
validator.settings - to show the settings that are loaded for the page.
CRM.$('#Main').valid(); to check if the form is "valid" - returns true/false.

I may well need to update the Stripe code to remove some of the overrides once this is merged. That's a good thing because we'll have more consistency and less need to hack around stuff :-)

[eileenmcnaughton]

@mattwire does this mean we should remove merge-ready?

[mattwire]

I'd like either @seamuslee001 or @demeritcowboy to do a quick test with the commands I've put up but I'm happy for this to be "merge ready" as if it does trigger any issues they are likely to be less than what there was before and we can work through to resolve those too. When I started looking at the jquery validation stuff we were in a pretty bad place with Civi, thanks to that initial work and then the work that @seamuslee001 has been doing we're really getting somewhere

[demeritcowboy]

Ok thanks that probably explains the stripe part. I'm good.

[mattwire]

Merging based on discussion and @demeritcowboy

[eileenmcnaughton]

Just noting this has caused an (unreleased) regression - https://lab.civicrm.org/dev/core/-/issues/1928#note_41814