Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate cleanup on failed - do not pass transaction, but use it #18022

Closed
wants to merge 1 commit into from

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 1, 2020

Overview

Alternative to #18020 focussing on failed - handles transaction fully within the failed function

Before

Transaction passed in (after no actions using it have been taken)

After

Transaction instantiated within failed function

Technical Details

Comments

@civibot
Copy link

civibot bot commented Aug 1, 2020

(Standard links)

@civibot civibot bot added the master label Aug 1, 2020
@eileenmcnaughton eileenmcnaughton changed the title Option 3 - do not pass transaction, but use it Alternate cleanup on failed - do not pass transaction, but use it Aug 1, 2020
@eileenmcnaughton
Copy link
Contributor Author

Closing as @seamuslee001 preferred the other approach

@eileenmcnaughton eileenmcnaughton deleted the failed branch August 1, 2020 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant