[REF] Stop instantiating transaction in PaypalIPN #18020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
commented
Aug 1, 2020
| @@ -214,7 +214,7 @@ public function loadObjects($input, &$ids, &$objects, $required, $paymentProcess | |||
| * @return bool | |||
| * @throws \CiviCRM_API3_Exception | |||
| */ | |||
| public function failed(&$objects, &$transaction, $input = []) { | |||
| public function failed(&$objects, $transaction = NULL, $input = []) { | |||
There was a problem hiding this comment.
We could instantiate a transaction within this function - but I think in the case of a crash not updating the contribution to failed would likely be worse than a partial update
|
@seamuslee001 so this would then mean I do this on the other classes & then #18016 - we could have a transaction within cancelled / failed. I'm not convinced - but I'm not opposed either |
|
@seamuslee001 this is the alternative approach #18022 |
|
This makes sense to me |
|
Test fail looks to be unrelated to me merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Don't istantiate pointless transactionn
Before
Transaction instantiated & passed around - but adds no real value
After
Not instantiated, except in completeOrder where it is done in the right place (in the BAO function)
Technical Details
I can do similar for PaypalProIPN & Anet IPN
Comments