[REF] Remove pass-by-reference & always empty param

[eileenmcnaughton]

Overview

Removes unused param, unnecessary pass by reference from function parameter

Before

public static function sendMail(&$input, &$ids, $contributionID, &$values,
                                  $returnMessageText = FALSE) {

After

public static function sendMail($input, $ids, $contributionID, $returnMessageText = FALSE) {

Technical Details

Once #17982 is merged there are only 2 places that call this function. In both
places

1. they instantiate an empty values array just to pass in
2. we can see they don't use input or ids afterwards, so they don't need to be passed by reference

Comments

Will not pass until #17982 is merged

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Added the has test flag as the test fails show we have test coverage in this area

CRM_Core_Payment_BaseIPNTest.testsendMailMembershipObjects
CRM_Core_Payment_BaseIPNTest.testSendMailMembershipObjectsNoLeakage
CRM_Core_Payment_BaseIPNTest.testsendMailMembershipWithoutLoadObjects
CRM_Core_Payment_BaseIPNTest.testComposeMailParticipant
CRM_Core_Payment_BaseIPNTest.testComposeMailParticipantObjects
CRM_Core_Payment_BaseIPNTest.testsendMailPledge

[eileenmcnaughton]

@seamuslee001 yep - it needs #17982 merged in order to pass

[seamuslee001]

Jenkins re test this please