[Ref] Move noisily deprecate BaseIPN->sendMail, call api from it rather than BAO function #17982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
isreceipt
branch
from
60dcf91 to
a880a78
Compare
eileenmcnaughton
changed the title
eileenmcnaughton
force-pushed
the
isreceipt
branch
from
a880a78 to
32434de
Compare
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jul 28, 2020
Once civicrm#17982 is merged there are only 2 places that call this function. In both places 1) they instantiate an empty values array just to pass in 2) we can see they don't use input or ids afterwards, so they don't need to be passed by reference
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jul 28, 2020
Once civicrm#17982 is merged there are only 2 places that call this function. In both places 1) they instantiate an empty values array just to pass in 2) we can see they don't use input or ids afterwards, so they don't need to be passed by reference
This function has been deprecated since 2015 and it's tempting just to remove it but at this stage it is being noisily deprecated & by-passed
eileenmcnaughton
force-pushed
the
isreceipt
branch
from
32434de to
5909727
Compare
|
CRM_Contribute_BAO_ContributionRecurTest.testAutoRenewalWhenOneMemberIsDeceased I can't see how that relates but if it's still there after another run I'll dig |
|
test this please |
eileenmcnaughton
changed the title
|
Jenkins re test this please |
|
@seamuslee001 looks like it has passed now |
|
This looks fine to me merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This function has been deprecated since 2015 and it's tempting just to remove it but at this stage
I'm just upping the noise, bypassing it in tests, and making it call the api so we have more of a free hand with the BAO function - notably it makes it clearer we don't need to have params by reference in the BAO function.
Before
Deprecated (& probably unused - certainly unused by core) BaseIPN function calls a BAO function
After
Deprecated (& probably unused - certainly unused by core) BaseIPN function calls the recommended api function.
Unused parameters removed from the signature
Only 2 places still call this BAO function the api and one other.
Technical Details
Baby cleanup step - facilitates #17984
Comments
Fun fact - these tests being altered are probably from our first ever test-driven refactor. They were written before moving the guts of the function out of the BaseIPN class & adding an api