Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unit Test] dev/core#1173 and dev/core#1827 - Test for activity tag search - PR 17655 #17755

Merged
merged 1 commit into from
Jul 5, 2020
Merged

[Unit Test] dev/core#1173 and dev/core#1827 - Test for activity tag search - PR 17655 #17755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 105 additions & 0 deletions tests/phpunit/CRM/Contact/BAO/ActivitySearchTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ public function tearDown() {
'civicrm_activity',
'civicrm_activity_contact',
'civicrm_uf_match',
'civicrm_entity_tag',
];
$this->quickCleanup($tablesToTruncate, TRUE);
$type = $this->callAPISuccess('optionValue', 'get', ['id' => $this->test_activity_type_id]);
Expand Down Expand Up @@ -207,4 +208,108 @@ public function testSearchByDetailsBoth() {
$this->checkArrayEquals($case['expected_contact'], $groupContacts);
}

/**
* Test that activity.get api works when filtering on bare tags (i.e. tags
* not part of a tagset).
*/
public function testSearchByBareTags() {
$tag = $this->callAPISuccess('Tag', 'create', [
'name' => 'a1',
'used_for' => 'Activities',
]);
$subject = 'test activity ' . __FUNCTION__;
$params = $this->_params;
$params['subject'] = $subject;
$activity = $this->callAPISuccess('Activity', 'Create', $params);
$this->callAPISuccess('EntityTag', 'create', [
'entity_id' => $activity['id'],
'entity_table' => 'civicrm_activity',
'tag_id' => 'a1',
]);
$case = [
'form_value' => [
// It looks like it can be an array or comma-separated string.
// The qill will be slightly different ("IN" vs. "OR").
// The search form seems to use commas.
'activity_tags' => (string) $tag['id'],
],
'expected_count' => 1,
'expected_contact' => [$this->_contactID],
];
$query = new CRM_Contact_BAO_Query(CRM_Contact_BAO_Query::convertFormValues($case['form_value']));
list($select, $from, $where, $having) = $query->query();

$expectedQill = [
0 => [
0 => 'Activity Tag = a1',
],
];
$this->assertEquals($expectedQill, $query->_qill);

$groupContacts = CRM_Core_DAO::executeQuery("SELECT DISTINCT contact_a.id $from $where")->fetchAll();
foreach ($groupContacts as $key => $value) {
$groupContacts[$key] = $value['id'];
}
$this->assertEquals($case['expected_count'], count($groupContacts));
$this->checkArrayEquals($case['expected_contact'], $groupContacts);

// Clean up. Don't want to use teardown to wipe the table since then
// the stock tags get wiped.
$this->callAPISuccess('Tag', 'delete', ['id' => $tag['id']]);
}

/**
* Test that activity.get api works when filtering on a tag in a tagset.
*/
public function testSearchByTagset() {
$tagset = $this->callAPISuccess('Tag', 'create', [
'name' => 'activity tagset',
'is_tagset' => 1,
'used_for' => 'Activities',
]);
$tag = $this->callAPISuccess('Tag', 'create', [
'name' => 'aa1',
'used_for' => 'Activities',
'parent_id' => 'activity tagset',
]);
$subject = 'test activity ' . __FUNCTION__;
$params = $this->_params;
$params['subject'] = $subject;
$activity = $this->callAPISuccess('Activity', 'Create', $params);
$this->callAPISuccess('EntityTag', 'create', [
'entity_id' => $activity['id'],
'entity_table' => 'civicrm_activity',
'tag_id' => 'aa1',
]);
$case = [
'form_value' => [
// If multiple tags the array element value is a comma-separated string
// and then the qill looks like "IN a OR b".
"activity_taglist" => [$tagset['id'] => (string) $tag['id']],
],
'expected_count' => 1,
'expected_contact' => [$this->_contactID],
];
$query = new CRM_Contact_BAO_Query(CRM_Contact_BAO_Query::convertFormValues($case['form_value']));
list($select, $from, $where, $having) = $query->query();

$expectedQill = [
0 => [
0 => 'Activity Tag IN aa1',
],
];
$this->assertEquals($expectedQill, $query->_qill);

$groupContacts = CRM_Core_DAO::executeQuery("SELECT DISTINCT contact_a.id $from $where")->fetchAll();
foreach ($groupContacts as $key => $value) {
$groupContacts[$key] = $value['id'];
}
$this->assertEquals($case['expected_count'], count($groupContacts));
$this->checkArrayEquals($case['expected_contact'], $groupContacts);

// Clean up. Don't want to use teardown to wipe the table since then
// the stock tags get wiped.
$this->callAPISuccess('Tag', 'delete', ['id' => $tag['id']]);
}

}