[Unit Test] dev/core#1173 and dev/core#1827 - Test for activity tag search - PR 17655

[demeritcowboy]

Overview

Failing test for #17655

For the second tagset test you get:

Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => Array (
-        0 => 'Activity Tag IN aa1'
+        0 => 'Activity Tag IN Non-profit'
     )
 )

@eileenmcnaughton @samuelsov

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@demeritcowboy based on you having written this should I now merge the other? (& merge this once it passes)

[demeritcowboy]

Yes could do that.

[demeritcowboy]

Fail as expected. So this should pass now the other PR has been merged. Jenkins retest this please and also pass this time.

CRM_Contact_BAO_ActivitySearchTest::testSearchByTagset
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => Array (
-        0 => 'Activity Tag IN aa1'
+        0 => 'Activity Tag IN Non-profit'
     )
 )

/home/jenkins/bknix-dfl/build/core-17755-4j6e2/web/sites/all/modules/civicrm/tests/phpunit/CRM/Contact/BAO/ActivitySearchTest.php:301
/home/jenkins/bknix-dfl/build/core-17755-4j6e2/web/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:209
/home/jenkins/bknix-dfl/extern/phpunit7/phpunit7.phar:615