Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] dev/core#1116 - Remove unused misnamed activityTypeName variable #16730

Merged
merged 1 commit into from
Mar 12, 2020
Merged

[REF] dev/core#1116 - Remove unused misnamed activityTypeName variable #16730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions CRM/Activity/Form/ActivityView.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,8 @@ public function preProcess() {
$params = ['id' => $activityId];
CRM_Activity_BAO_Activity::retrieve($params, $defaults);

// Set activity type name and description to template.
list($activityTypeName, $activityTypeDescription) = CRM_Core_BAO_OptionValue::getActivityTypeDetails($defaults['activity_type_id']);

// activityTypeName - dev/core#1116-unknown-if-ok
// It seems like activityTypeName is no longer used? Description is still used though. See PR notes for more details.
$this->assign('activityTypeName', $activityTypeName);
// Send activity type description to template.
list(, $activityTypeDescription) = CRM_Core_BAO_OptionValue::getActivityTypeDetails($defaults['activity_type_id']);
$this->assign('activityTypeDescription', $activityTypeDescription);

if (!empty($defaults['mailingId'])) {
Expand Down