[REF] dev/core#1116 - Remove unused misnamed activityTypeName variable

[demeritcowboy]

Overview

"Fixes" another reference to activityTypeName where Name means Label, but this time by removing it since it's not used.

Technical Details

The variable activityTypeName (which is label - see https://github.com/civicrm/civicrm-core/blob/5.23.0/CRM/Core/BAO/OptionValue.php#L288) used to be used in ActivityView.tpl but was removed in

c27ebe4#diff-82708b475d546c52a906d4e34ff6dbbc

(and then that temporary placeholder was removed in b0a72b3#diff-82708b475d546c52a906d4e34ff6dbbc)

The only files ActivityView.tpl further {include}'s is formButtons, so it isn't used in an {include}.

It's possible some local customization on a site is using it in their smarty template, but I don't think you can deprecate smarty variables.

The local php variable in ActivityView.php isn't used anywhere else in the file.

Comments

The diff seems easier to read in github if you use split view instead of unified.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I agree this is unused. Test fail unrelated

Screenshot is the same before & after - why do we put subject so low down? & date & status - they should all be at the top - sigh

[demeritcowboy]

Thanks!