dev/core#1636 - In system status check avoid E_NOTICEs for smart groups that don't have form_values[0]

[demeritcowboy]

Overview

In some installs where smart groups are defined differently, you get Undefined index 0 line 109 in CRM/Utils/Check/Component/Schema.php when first logging in. They also happen on the system status page but you don't see them there because they get snippet'd out, but they appear in drupal watchdog.

Related lab tickets:

• https://lab.civicrm.org/dev/core/issues/1636
• https://lab.civicrm.org/dev/core/issues/1471
• https://lab.civicrm.org/dev/core/issues/1555

Technical Details

In PR #16267 a check for deleted custom fields in smart groups was added. For whatever reason, as also addressed in #16417, some smart groups don't have a form_values[0], so you get undefined index notices.

I've just applied the same fix/workaround as in #16417

Comments

Started in 5.23 so have based against 5.24. It's just a system status check so not sure it needs to be backported, although you see the notices every time you log in.

FYI @jitendrapurohit @jmcclelland

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Yeh I think this might have something to do with how the smart groups have been generated @eileenmcnaughton thoughts

[eileenmcnaughton]

I think it's OK to merge this - the lack of formValue is a little scary -but outside the scope of this check to worry about