avoid undefined offset and uninitialized key errors on upgrade - dev/core#1555 #16417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://lab.civicrm.org/dev/core/issues/1555
Overview
See https://lab.civicrm.org/dev/core/issues/1555
When upgrading, there are a lot of php notices along the lines of:
Before
The errors fill the screen.
After
The errors do not show up.
Technical Details
The SmartGroup upgrade code makes an assumption about the formValues in a given database that is not true for all data.