Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Down with php4 compatibility #14847

Merged
merged 1 commit into from
Jul 20, 2019
Merged

[REF] Down with php4 compatibility #14847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions CRM/Core/Report/Excel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ class CRM_Core_Report_Excel {
* Outputs a result set with a given header
* in the string buffer result
*
* @param string $header
* (reference ) column headers.
* @param string $rows
* (reference ) result set rows.
* @param null $titleHeader
* @param array $header
* column headers.
* @param array $rows
* result set rows.
* @param string $titleHeader
* @param bool $print
* Should the output be printed.
* @param bool $outputHeader
Expand All @@ -51,7 +51,7 @@ class CRM_Core_Report_Excel {
* empty if output is printed, else output
*
*/
public static function makeCSVTable(&$header, &$rows, $titleHeader = NULL, $print = TRUE, $outputHeader = TRUE) {
public static function makeCSVTable($header, $rows, $titleHeader = NULL, $print = TRUE, $outputHeader = TRUE) {
if ($titleHeader) {
echo $titleHeader;
}
Expand Down Expand Up @@ -159,7 +159,7 @@ public static function makeCSVTable(&$header, &$rows, $titleHeader = NULL, $prin
* @param null $titleHeader
* @param bool $outputHeader
*/
public function writeHTMLFile($fileName, &$header, &$rows, $titleHeader = NULL, $outputHeader = TRUE) {
public function writeHTMLFile($fileName, $header, $rows, $titleHeader = NULL, $outputHeader = TRUE) {
if ($outputHeader) {
CRM_Utils_System::download(CRM_Utils_String::munge($fileName),
'application/vnd.ms-excel',
Expand Down Expand Up @@ -206,7 +206,7 @@ public function writeHTMLFile($fileName, &$header, &$rows, $titleHeader = NULL,
*
* @return void
*/
public static function writeCSVFile($fileName, &$header, &$rows, $titleHeader = NULL, $outputHeader = TRUE, $saveFile = NULL) {
public static function writeCSVFile($fileName, $header, $rows, $titleHeader = NULL, $outputHeader = TRUE, $saveFile = NULL) {
if ($outputHeader && !$saveFile) {
CRM_Utils_System::download(CRM_Utils_String::munge($fileName),
'text/x-csv',
Expand Down