Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Down with php4 compatibility #14847

Merged
merged 1 commit into from
Jul 20, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Removes a few more cases where parameters are needlessly passed as references

Before

Better support for php4

After

Worse support for php 4

Technical Details

Part of ongoing cleanup removing unnecessary pass-by-references (which allows code simplication). The key is to check whether the parameters are changes anywhere in the function - if not we are not achieving anything by passing by ref

Comments

Removes a few more cases where parameters are needlessly passed as references
@civibot
Copy link

civibot bot commented Jul 20, 2019

(Standard links)

@civibot civibot bot added the master label Jul 20, 2019
@colemanw colemanw merged commit ba093e9 into civicrm:master Jul 20, 2019
@colemanw colemanw deleted the silly_refs branch July 20, 2019 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants